Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Font responsiveness #1110

Merged
merged 7 commits into from
Jan 19, 2024
Merged

Fix: Font responsiveness #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b8943b
Comment out font size for h2 to h5 in _base.scss
adiati98 Jan 7, 2024
88106a5
Add className of mt-3 to h1
adiati98 Jan 7, 2024
f40ae1b
Merge branch 'main' of https://github.com/Virtual-Coffee/virtualcoffe…
adiati98 Jan 7, 2024
135e1e6
only apply margin to smaller breakpoint
danieltott Jan 19, 2024
9ece3db
remove commented out code
danieltott Jan 19, 2024
f2fd2df
adjust heading line height
danieltott Jan 19, 2024
3abaeba
Adjust hero alignment
danieltott Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/components/layouts/DefaultLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,15 @@ export function HeroHead({
<div className="py-4">
<div className="container">
<div className="row align-items-center">
<div className="col-sm-4">
<div className="col-md-4 text-center">
<UndrawIllustration
loading="eager"
style={{ width: '100%' }}
style={{ width: '100%', maxWidth: '300px' }}
filename={heroData.Hero}
/>
</div>
<div className="col-sm-8">
<h1 className="display-4">{heroData.heroHeader}</h1>
<div className="col-md-8">
<h1 className="display-4 mt-3 mt-md-0">{heroData.heroHeader}</h1>
{heroData.heroSubheader && (
<div className="lead">{heroData.heroSubheader}</div>
)}
Expand Down
12 changes: 0 additions & 12 deletions styles/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,6 @@ ul {
}
}

.prose h1 {
// text-align: center;
}

.prose h1 > small::before {
content: '\a';
white-space: pre;
Expand All @@ -177,7 +173,6 @@ ul {
}

.prose h3 {
font-size: 1.5rem;
font-weight: 600;
margin: 1.5rem 0 0.5rem 0;
}
Expand Down Expand Up @@ -217,25 +212,18 @@ ul {
}

.resources-section .prose h2 {
font-size: 3rem;
font-weight: 900;
line-height: 1.2;
margin-bottom: 1rem;
}

.resources-section .prose h3 {
margin: 1.5rem 0 1.5rem 0;
font-size: 2rem;
}

.resources-section .prose h4 {
margin: 1.5rem 0 1rem 0;
font-weight: 500;
font-size: 1.25rem;
}

.resources-section .prose h5 {
font-size: 1rem;
}

.resources-section .prose .header-anchor-wrapper-h2 {
Expand Down
1 change: 1 addition & 0 deletions styles/_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ $font-family-sans-serif: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto,
$font-family-base: 'Inter var', $font-family-sans-serif;

$headings-font-weight: 700;
$headings-line-height: 1;

$display1-weight: 900;
$display2-weight: 900;
Expand Down
Loading