-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Test coverage for TimeCNNNetwork Improved #2534
[ENH] Test coverage for TimeCNNNetwork Improved #2534
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than comment on testing not None
rather than an instance of tf layers, lgtm, I'll let @hadifawaz1999 give it a look for approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, could you explicity mention "time_cnn" in the test name functions ? also your trick of the "should_raise" in the other PRs, could you also do it here to improve coverage more ? (unless you do it and i didnt see it) thanks
Hi, I have made the above changes - changing the names to "test_tim_cnn" and checking all the valid error case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changed implemented.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Contributes to #2497. Reference PRs #2518.
The given issue improvises the test coverage of TimeCNNNetwork class.
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
No
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access