Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart: bump app version to v0.20.0 #852

Merged

Conversation

bmorton
Copy link
Contributor

@bmorton bmorton commented Nov 22, 2024

This bumps the app version to v0.20.0 and updates the prepare-release task in the Makefile to update the appVersion in the Helm chart.

@alexandrevilain
Copy link
Owner

Thanks, this was indeed missing.
CRDs were updated in 0.20.
Could you please update them ? Thanks :)

@bmorton
Copy link
Contributor Author

bmorton commented Nov 24, 2024

Ah-ha! I missed the make helm target there before. It looks like appVersion is all automated too so I pulled that out of prepare-release. I think this should look more complete now!

@bmorton
Copy link
Contributor Author

bmorton commented Nov 24, 2024

Alright -- I figured out that appVersion wasn't being updated and I ended up moving that to the helm target. When I run make helm now, it seems like everything is packaged properly.

How does this look now?

@alexandrevilain
Copy link
Owner

It looks great ! 👍

@alexandrevilain alexandrevilain merged commit abf68cf into alexandrevilain:main Nov 29, 2024
10 checks passed
@bmorton bmorton deleted the bump-chart-app-version-to-v0.20.0 branch November 29, 2024 08:27
@bmorton
Copy link
Contributor Author

bmorton commented Dec 2, 2024

I went to pull down v0.6.0, but noticed that it wasn't available. Is there another step to getting this published?

@ttretau
Copy link
Contributor

ttretau commented Dec 5, 2024

Hi @bmorton ,
I think the chart release failed in the Github Action due to be failing with different GNU sed.
Adding #866 to fix this..

@ttretau
Copy link
Contributor

ttretau commented Dec 5, 2024

We might need now to run the workflow manually, because there was no change in charts/.. @alexandrevilain 🙌

@alexandrevilain
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants