Set research-approved default module param values #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relyt29
requested review from
xmariachi,
felipead,
jmdkastro,
fernandofcampos,
kpeluso,
spooktheducks,
amimart,
guilherme-brandao,
fstecker and
cal-hawk
|
I am deleting the failing test that was surfaced by this PR. For reasoning, see https://linear.app/alloralabs/issue/PROTO-3088/testtotalinferersrewardfractiongrowswithmoreinferers-is-flawed-needs |
relyt29
force-pushed
the
tyler/res-579-due-diligence-on-rewards
branch
from
66fa68d to
c60518d
Compare
…eeds rewrite. See PROTO-3088 for details
relyt29
force-pushed
the
tyler/res-579-due-diligence-on-rewards
branch
from
c60518d to
9385a19
Compare
fernandofcampos
previously approved these changes
Dec 18, 2024
Signed-off-by: Kenny P <17100641+kpeluso@users.noreply.github.com>
kpeluso
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
In RES-579 Research found either a typo or miscommunication in our tuning of the default
p_rewardvalues. We had inferers set to 1 and reputers set to 3 instead of the other way around. This was fixed on testnet with a transaction, however for genesis.json generation it is also good to fix it in the default chain parameter values.Link(s) to Ticket(s) or Issue(s) resolved by this PR
RES-579
Are these changes tested and documented?
These changes are minimal tuning configurations. Our existing unit tests will cover these cases.