Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set research-approved default module param values #711

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Set research-approved default module param values #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b19f25b
Set research-approved default module param values
relyt29 Dec 17, 2024
9385a19
TestTotalInferersRewardFractionGrowsWithMoreInferers commented out: n…
relyt29 Dec 17, 2024
a327ba4
Merge branch 'dev' into tyler/res-579-due-diligence-on-rewards
kpeluso Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* [#699](https://github.com/allora-network/allora-chain/pull/699) Make install script manage new release assets naming
* [#704](https://github.com/allora-network/allora-chain/pull/704) Correct Discrepancies with Whitepaper modified reward fractions vs plain EMA
* [#700](https://github.com/allora-network/allora-chain/pull/700) Allow clients to unmarshall old transactions
* [#711](https://github.com/allora-network/allora-chain/pull/711) Set research-approved default module param values
* [#713](https://github.com/allora-network/allora-chain/pull/713) Proto generation keeps codec.go files

### Security
Expand Down
2 changes: 2 additions & 0 deletions x/emissions/module/rewards/rewards_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2391,6 +2391,7 @@ func (s *RewardsTestSuite) TestOnlyFewTopActorsGetReward() {
s.Require().Equal(uint64(len(forecasterScores)), params.GetMaxTopForecastersToReward(), "Only few Top forecasters can get reward")
}

/* to be rewritten in PROTO-3088
func (s *RewardsTestSuite) TestTotalInferersRewardFractionGrowsWithMoreInferers() {
block := int64(100)
s.ctx = s.ctx.WithBlockHeight(block)
Expand Down Expand Up @@ -2918,6 +2919,7 @@ func (s *RewardsTestSuite) TestTotalInferersRewardFractionGrowsWithMoreInferers(
thirdInfererFraction.String(),
)
}
*/

// TestRewardForTopicGoesUpWhenRelativeStakeGoesUp tests that the reward for a topic increases
// when its relative stake compared to other topics increases.
Expand Down
6 changes: 5 additions & 1 deletion x/emissions/module/rewards/scores_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1379,6 +1379,7 @@ func generateWorkerDataBundles(s *RewardsTestSuite, blockHeight int64, topicId u
return inferences
}

/* to be rewritten in PROTO-3088
func generateMoreInferencesDataBundles(s *RewardsTestSuite, blockHeight int64, topicId uint64) []*types.WorkerDataBundle {
var newInferences []*types.WorkerDataBundle
worker1 := 13
Expand Down Expand Up @@ -1427,7 +1428,7 @@ func generateMoreInferencesDataBundles(s *RewardsTestSuite, blockHeight int64, t
TopicId: topicId,
BlockHeight: blockHeight,
Inferer: s.addrsStr[worker2],
Value: alloraMath.MustNewDecFromString("0.01251"),
Value: alloraMath.MustNewDecFromString("10000"),
ExtraData: nil,
Proof: "",
},
Expand Down Expand Up @@ -1462,7 +1463,9 @@ func generateMoreInferencesDataBundles(s *RewardsTestSuite, blockHeight int64, t

return newInferences
}
*/

/* to be rewritten in PROTO-3088
func generateMoreForecastersDataBundles(s *RewardsTestSuite, blockHeight int64, topicId uint64) []*types.WorkerDataBundle {
var newForecasts []*types.WorkerDataBundle
worker1 := 13
Expand Down Expand Up @@ -1546,6 +1549,7 @@ func generateMoreForecastersDataBundles(s *RewardsTestSuite, blockHeight int64,

return newForecasts
}
*/

type TestWorkerValue struct {
Index int
Expand Down
4 changes: 2 additions & 2 deletions x/emissions/types/params.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ func DefaultParams() Params {
MinEpochLengthRecordLimit: int64(3), // minimum number of epochs to keep records for a topic
MaxSerializedMsgLength: int64(1000 * 1000), // maximum size of data to msg and query server in bytes
BlocksPerMonth: uint64(864000), // ~3 seconds block time, assuming 30 days in a month 60 * 60 * 24 * 30 / 3
PRewardInference: alloraMath.NewDecFromInt64(1), // fiducial value for rewards calculation
PRewardInference: alloraMath.NewDecFromInt64(3), // fiducial value for rewards calculation
PRewardForecast: alloraMath.NewDecFromInt64(3), // fiducial value for rewards calculation
PRewardReputer: alloraMath.NewDecFromInt64(3), // fiducial value for rewards calculation
PRewardReputer: alloraMath.NewDecFromInt64(1), // fiducial value for rewards calculation
CRewardInference: alloraMath.MustNewDecFromString("0.75"), // fiducial value for rewards calculation
CRewardForecast: alloraMath.MustNewDecFromString("0.75"), // fiducial value for rewards calculation
CNorm: alloraMath.MustNewDecFromString("0.75"), // fiducial value for inference synthesis
Expand Down
4 changes: 2 additions & 2 deletions x/emissions/types/params_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ func TestDefaultParams(t *testing.T) {
MinEpochLengthRecordLimit: int64(3),
MaxSerializedMsgLength: int64(1000 * 1000),
BlocksPerMonth: uint64(864000),
PRewardInference: alloraMath.NewDecFromInt64(1),
PRewardInference: alloraMath.NewDecFromInt64(3),
PRewardForecast: alloraMath.NewDecFromInt64(3),
PRewardReputer: alloraMath.NewDecFromInt64(3),
PRewardReputer: alloraMath.NewDecFromInt64(1),
CRewardInference: alloraMath.MustNewDecFromString("0.75"),
CRewardForecast: alloraMath.MustNewDecFromString("0.75"),
CNorm: alloraMath.MustNewDecFromString("0.75"),
Expand Down
Loading