Reuse alias if possible #14781
Draft
Reuse alias if possible #14781
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
|
Interestingly, I was working on a very similar PR last night: |
|
yes, @alamb, I think we got on the same issue with |
Yes, indeed -- something is going on with unnest. It would be great if you wanted to take over Feel free to pull over the test case from https://github.com/apache/datafusion/pull/15008/files as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Currently, alias over alias creates an extra expression layer, which gets merged in
optimize_projectionsthrough an expensive recursive functionWhat changes are included in this PR?
A small change to reuse an existing alias when possible. This affects two cases:
optimize_projectionsisn't called (e.g., when there's only one projection andmerge_consecutive_projectionsisn't run)Are these changes tested?
Extended doctest
Are there any user-facing changes?
No.