Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not double alias Exprs #15008

Closed
wants to merge 3 commits into from
Closed

Do not double alias Exprs #15008

wants to merge 3 commits into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 4, 2025

Which issue does this PR close?

Rationale for this change

Nested Expr::Alias is confusing for display and for dealing with code

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt) labels Mar 4, 2025
@github-actions github-actions bot added the optimizer Optimizer rules label Mar 5, 2025
This was referenced Mar 4, 2025
@alamb
Copy link
Contributor Author

alamb commented Mar 5, 2025

Let's go with @blaginin 's version here:

@alamb alamb closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logical-expr Logical plan and expressions optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove duplicated alias in Sort
1 participant