Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to 1.78.0 #424

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Update Rust to 1.78.0 #424

merged 1 commit into from
Mar 12, 2025

Conversation

sksat
Copy link
Member

@sksat sksat commented Mar 12, 2025

  • Rust 1.83.0 から、lockfile v4 が default になった
  • ところで、Renovate が依存を更新する時は、内部で cargo update が叩かれている
    • そして、(おそらく)Renovate のコンテナが抱えている Rust のバージョンで更新が行われる
    • Cargo.lock が v4 になった状態で commit される
  • しかし、lockfile v4 は 1.78.0 で stabilize された
    • ということは、Rust 1.77.0 以前では v4 な Cargo.lockが発生するとビルドがコケる
  • そのため、一旦 1.78.0 に上げる

@sksat sksat requested a review from Copilot March 12, 2025 02:18
@sksat sksat self-assigned this Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Rust toolchain version to 1.78.0 to ensure compatibility with Cargo.lock v4 generated by Renovate.

  • Updated the Rust channel in rust-toolchain.toml from 1.76.0 to 1.78.0
  • Ensures that build environments using Rust prior to 1.78.0 no longer encounter issues with lockfile v4
Copy link
Member

@ymgyt ymgyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です

@sksat sksat merged commit 88fe62b into main Mar 12, 2025
37 checks passed
@sksat sksat deleted the feature/update-rust-1.78 branch March 12, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants