Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GOCACHE under OUT_DIR #603

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Set GOCACHE under OUT_DIR #603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80525c4
Set GOCACHE under OUT_DIR
justsmth Nov 19, 2024
4ccf2d7
PR feedback
justsmth Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions aws-lc-fips-sys/builder/cmake_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,14 @@ impl CmakeBuilder {
cmake::Config::new(&self.manifest_dir)
}

const GOCACHE_DIR_NAME: &'static str = "go-cache";
#[allow(clippy::too_many_lines)]
fn prepare_cmake_build(&self) -> cmake::Config {
env::set_var(
"GOCACHE",
self.out_dir.join(Self::GOCACHE_DIR_NAME).as_os_str(),
);
Comment on lines +95 to +98
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Ideally if the user has this environment variable set to something we don't override it.


let mut cmake_cfg = self.get_cmake_config();

if OutputLibType::default() == OutputLibType::Dynamic {
Expand Down
Loading