Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interop test generation #113

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Fix interop test generation #113

merged 4 commits into from
Mar 14, 2024

Conversation

mulmarta
Copy link
Contributor

This PR fixes passive_client* interop test vectors:

  • The key packages in the test vectors expired last week which broke tests for other implementations, so now we make the lifetime eternal.
  • Test generation was broken due to multiple small bugs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner March 14, 2024 13:34
@mulmarta mulmarta changed the title Fix interop test gen Fix interop test generation Mar 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 89.45%. Comparing base (8e74976) to head (12cac58).

Files Patch % Lines
mls-rs/src/client_builder.rs 55.55% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   89.47%   89.45%   -0.02%     
==========================================
  Files         173      173              
  Lines       31270    31296      +26     
==========================================
+ Hits        27978    27996      +18     
- Misses       3292     3300       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stefunctional
stefunctional previously approved these changes Mar 14, 2024
Marta Mularczyk and others added 4 commits March 14, 2024 13:32
Co-authored-by: Stephane Raux <94983192+stefunctional@users.noreply.github.com>
@tomleavy tomleavy force-pushed the fix-interop-test-gen branch from b90dd1f to 12cac58 Compare March 14, 2024 17:32
@mulmarta mulmarta merged commit 4383d08 into main Mar 14, 2024
20 checks passed
@mulmarta mulmarta deleted the fix-interop-test-gen branch March 14, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants