[uniffi] Turn more types into UniFFI records #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefunctional
previously approved these changes
Mar 18, 2024
tomleavy
previously approved these changes
Mar 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 89.34% 89.45% +0.11%
==========================================
Files 173 173
Lines 31333 31322 -11
==========================================
+ Hits 27993 28018 +25
+ Misses 3340 3304 -36 ☔ View full report in Codecov by Sentry. |
mulmarta
reviewed
Mar 18, 2024
This simplifies the Kotlin API since records don’t have the `close` method that objects have. The downside is that creating the record requires you to eagerly create the data for all record fields.
mgeisler
force-pushed
the
uniffi-records
branch
from
87c1255 to
d5925c1
Compare
|
Thanks all for the great review! The Clone Wars have been won, no more |
mulmarta
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #81.
Description of changes:
As discussed in #112 (comment) onwards, the Kotlin code generated by UniFFI becomes simpler when we use
uniffi::Recordinstead ofuniffi::Object. This PR turnsCommitOutput,SignaturePublicKey,SignatureSecretKey, andRatchetTreeinto records.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.