Chore/fix eslint #733
Merged
Chore/fix eslint #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use a new config BREAKING CHANGE: The whole codebase has to be reformatted
Old eslint config was deprecated, broken and irrelevant. Fix it, and update all of the files in the repo. BREAKING CHANGE: This is a scary huge commit, but it's mostly styling etc. Should be tested on staging
TheDivic
added
the
🧹 Chore
TheDivic
requested review from
veljkovranic,
joepegler,
TakGN and
nishant-1391
joepegler
approved these changes
Oct 26, 2024
joepegler
reviewed
Oct 26, 2024
.husky/pre-commit
Outdated
| @@ -1,4 +1,2 @@ | |||
| #!/usr/bin/env sh | |||
| . "$(dirname -- "$0")/_/husky.sh" | |||
|
|
|||
| yarn run format | |||
There was a problem hiding this comment.
This means commits will no longer be auto-formatted?
There was a problem hiding this comment.
Had to disable it for now, as soon as I merge this PR I'll re-enable it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Context
Type of change
Why are we doing this?
What did we do?
A very scary 😱 PR that updates the eslint config and many, many source files in our codebase. There's no behavior change, just style.
How Has This Been Tested?
yarn eslintreports no errors👀 How do I review this?