-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define interfaces by tests #312
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
===========================================
+ Coverage 64.76% 86.24% +21.47%
===========================================
Files 36 34 -2
Lines 2401 2428 +27
===========================================
+ Hits 1555 2094 +539
+ Misses 846 334 -512 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines a series of functions for testing whether a type fulfills some interface. This is the first step on replacing our current
Quantum
&Ansatz
classes, that act as concrete mixins for other classes, forPluggable
andAnsatz
abstract interfaces. By adding these tests, we test for API breakage while we refactor internals.This should allow us to fix the type hierarchy serialization problems we suffer from Julia's single-inheritance enforcement, while also avoiding the diamond problem and schizofrenia-like problems of multiple-inheritance OOP.