-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created rich_link_controller and functionalities #227
Conversation
The Elixir part should be working now. Sharing the HTML generated by the phoenix server worked on WhatsApp, Slack and Facebook. Twitter was not yet tested. Some of the next steps that I have discussed with @NeoVier: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bro, when the bio has markdown we don't render it properly, like you can see on https://api.staging.cambiatus.io/api/rich_link/profile/lucca (I've published it to staging).
Using I've tried approaching it using So I believe we should try to use |
Ok @MatheusBuss! Np for pandoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also tests? 😬 🔧
Still to do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its getting better and better bro! Keep it up!
a URL precisa ser pra tela do perfil, ao invés do email |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long time to work on the review @MatheusBuss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked the instructions. Just followed it now and tested on telegram.
here is the result for this URL: https://api.staging.cambiatus.io/api/rich_link/profile/lucca
I'm missing the photo and we also have a tag that was not rendered correctly.
Also its rendering some sort of lorem ipsum, even if my profile don't have it:
That's odd. I tested on Telegram and had the same result, but on WhatsApp it renders correctly (other than the underline tag and the image) Even checking the html on the page it doesn't have any lorem ipsum in it. Don't know why it shows on Telegram, maybe it's cached from previous tests?
We should try to use an URL withouth the |
Exactly this. I found @webpagebot on this thread . It clears the cache on telegram. Now the description is updated! |
Great bro this is awesome! Can we also preview the profile image when sharing profile links? |
I was looking into it, and the html does include the image link, but it isn't loading. I tried downloading based on the link and noticed that the file doesn't have the extension (.jpeg or .png) so it could be that. |
I see bro, in this case can you open a new issue for us to transform images on this link? This way we can tackle this in a part two |
Created cambiatus/lambda-functions#2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! congrats bro!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💰 🔗
🎉
What issue does this PR close
Closes #182
Changes Proposed (a list of new changes introduced by this PR)
Add rich link/preview when Cambiatus andand associated links are shared in different social medias
How to test ( a list of instructions on how to test this PR)
mix phx.server
2.1. For User sharing send
GET
request to/api/rich_link/profile/#{user_name}
2.2. For Product sharing send
GET
request to/api/rich_link/shop?id=#{product_id}
2.3. For Community sharing send
GET
request to/api/rich_link
(Use the host header in the HTTP request for the appropriate community)Example of sharing html generated by these changes through Whatsapp: