Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bitnami kubeprod as installation method #1253

Closed
wants to merge 2 commits into from

Conversation

mprochowski
Copy link

PR is based on the issue #1241

In the "Installation > Other tools" page, the Bitnami kubeprod project is listed as an alternative method to install cert-manager. However, that project has been archived two years ago and hasn't been updated since. See announcement for further details.

So this page is no longer needed in the newest version of the documentation.

Signed-off-by: Michał Prochowski <michal@prochowski.pl>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mprochowski
Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Michał Prochowski <michal@prochowski.pl>
@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 7ebd9ed
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/64916848e476a300081493d0
😎 Deploy Preview https://deploy-preview-1253--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks so much for raising this! Always appreciate updates to this kind of doc which doesn't get looked at much!

I've added a comment - what do you think? 😁

Comment on lines -42 to -45
{
"title": "Other tools",
"path": "/docs/installation/other-tools.md"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Rather than entirely removing this page, could we maybe replace the kubeprod installation instructions with a notice saying that it's no longer supported?

If we remove this page it'll break any links that people have to the page and we try to avoid that!

(another approach is to add a redirect from the old older-tools page to a different page, but that might be confusing!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd favor leaving a deprecation note instead of removing a page entirely.

I'd also favor explaining why things are deprecated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is clear that the kube-prod-runtime project is archived & should not be used anymore.
I think it is good to simplify the side menu and remove this item.
For that reason, I would prefer just adding a redirect.

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2023
@jetstack-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@inteon
Copy link
Member

inteon commented Nov 20, 2023

Thanks @mprochowski we included your proposed change in #1311.

@inteon inteon closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants