-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Bitnami kubeprod as installation method #1253
Conversation
Signed-off-by: Michał Prochowski <michal@prochowski.pl>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mprochowski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Michał Prochowski <michal@prochowski.pl>
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks so much for raising this! Always appreciate updates to this kind of doc which doesn't get looked at much!
I've added a comment - what do you think? 😁
{ | ||
"title": "Other tools", | ||
"path": "/docs/installation/other-tools.md" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Rather than entirely removing this page, could we maybe replace the kubeprod installation instructions with a notice saying that it's no longer supported?
If we remove this page it'll break any links that people have to the page and we try to avoid that!
(another approach is to add a redirect from the old older-tools page to a different page, but that might be confusing!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd favor leaving a deprecation note instead of removing a page entirely.
I'd also favor explaining why things are deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is clear that the kube-prod-runtime project is archived & should not be used anymore.
I think it is good to simplify the side menu and remove this item.
For that reason, I would prefer just adding a redirect.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @mprochowski we included your proposed change in #1311. |
PR is based on the issue #1241
So this page is no longer needed in the newest version of the documentation.