Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bitnami kubeprod as installation method #1253

Closed
wants to merge 2 commits into from
Closed

Remove Bitnami kubeprod as installation method #1253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8349e80
Delete other-tools.md
mprochowski Jun 20, 2023
7ebd9ed
Removing other tools from manifest.json
mprochowski Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions content/docs/installation/other-tools.md
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions content/docs/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@
"title": "OperatorHub (OLM)",
"path": "/docs/installation/operator-lifecycle-manager.md"
},
{
"title": "Other tools",
"path": "/docs/installation/other-tools.md"
},
Comment on lines -42 to -45
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Rather than entirely removing this page, could we maybe replace the kubeprod installation instructions with a notice saying that it's no longer supported?

If we remove this page it'll break any links that people have to the page and we try to avoid that!

(another approach is to add a redirect from the old older-tools page to a different page, but that might be confusing!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd favor leaving a deprecation note instead of removing a page entirely.

I'd also favor explaining why things are deprecated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is clear that the kube-prod-runtime project is archived & should not be used anymore.
I think it is good to simplify the side menu and remove this item.
For that reason, I would prefer just adding a redirect.

{
"title": "Verifying",
"path": "/docs/installation/verify.md"
Expand Down