Dyno: resolve bug in de/serialize generation, and other fixes #26631
+56
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Harshbarger <ben.harshb@gmail.com>
… type Signed-off-by: Ben Harshbarger <ben.harshb@gmail.com>
Signed-off-by: Ben Harshbarger <ben.harshb@gmail.com>
Signed-off-by: Ben Harshbarger <ben.harshb@gmail.com>
Signed-off-by: Ben Harshbarger <ben.harshb@gmail.com>
DanilaFe
approved these changes
Jan 31, 2025
| @@ -4036,10 +4036,14 @@ static bool resolveFnCallSpecial(Context* context, | |||
| // cast (borrowed class) : unmanaged | |||
There was a problem hiding this comment.
"and unmanaged to borrowed"
| result = QualifiedType(QualifiedType::CONST_VAR, VoidType::get(context)); | ||
| return true; | ||
| } else { | ||
| result = QualifiedType(QualifiedType::CONST_VAR, ErroneousType::get(context)); |
There was a problem hiding this comment.
I think we're trying to move to using ErroneousType only when an error would be emitted. Since there's no error, I think UnknownType is what should be returned here, or an error issued.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a trivial off-by-one bug with the generation of de/serialize formals. While poking further at IO calls, I observed some other issues with resolution and made some fixes:
borrowed classas an actual, which can occur inisSubtypeThis PR also adds some tests to lock in this behavior.
Testing: