Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dyno: resolve bug in de/serialize generation, and other fixes #26631

Merged
merged 6 commits into from
Jan 31, 2025
Prev Previous commit
Next Next commit
Allow casts to/from both unmanaged and borrowed class types
Signed-off-by: Ben Harshbarger <ben.harshb@gmail.com>
  • Loading branch information
benharsh committed Jan 30, 2025
commit ea5ab6674cddac62da439bdb4168ee8c499871d5
12 changes: 8 additions & 4 deletions frontend/lib/resolution/resolution-queries.cpp
Original file line number Diff line number Diff line change
@@ -4036,10 +4036,14 @@ static bool resolveFnCallSpecial(Context* context,
// cast (borrowed class) : unmanaged
auto srcClass = srcTy->toClassType();
auto dstClass = dstTy->toClassType();
if (srcClass->decorator().isBorrowed() &&
dstClass->manageableType()->isAnyClassType() &&
dstClass->decorator().isUnmanaged()) {
auto decorator = ClassTypeDecorator(ClassTypeDecorator::ClassTypeDecoratorEnum::UNMANAGED);
bool isValidDst = dstClass->manageableType()->isAnyClassType() &&
(dstClass->decorator().isUnmanaged() ||
dstClass->decorator().isBorrowed());
bool isValidSrc = srcClass->decorator().isBorrowed() ||
srcClass->decorator().isUnmanaged();
if (isValidDst && isValidSrc) {
auto management = ClassTypeDecorator::removeNilableFromDecorator(dstClass->decorator().val());
auto decorator = ClassTypeDecorator(management);
decorator = decorator.copyNilabilityFrom(srcClass->decorator());
auto outTy = ClassType::get(context, srcClass->manageableType(),
nullptr, decorator);