Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vitess analysis document. #284

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

dwelsch-esi
Copy link
Collaborator

@dwelsch-esi dwelsch-esi commented Feb 19, 2025

Resolves: #280

Signed-off-by: Dave Welsch <dwelsch@expertsupport.com>
- Advanced > Distributed Atomic Transactions
- Migration

There is one special-purpose FAQ, for VReplication in the Reference.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have this FAQ as well
https://vitess.io/docs/faq/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK. It's outside the versioned documentation so I missed it. There's a lot of good information here; I'll have a look and revise the analysis and recommendations!

**Localization & i18n directories**: Are you planning for localization/internationalization
with regard to site directory structure?

Yes, there are full versions of the documentation in both English and Chinese.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been debating removing the Chinese documentation because it is being simply copied over for each new release without any content updates.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepthi You mean you're copying a down-level version of the documentation without the updates for new releases? Which version of the documentation is the current Chinese version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend keeping it, but maybe stop versioning it, or suggest it's archived or deprecated somehow.

but it should be presented explicitly as a step in the procedure.

Further down the page, another backup option, *Using mysqlshell*, has the same shortcomings:
No actual command is presented.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commands are presented towards the end of the page https://vitess.io/docs/21.0/user-guides/operating-vitess/backup-and-restore/creating-a-backup/
Maybe the page needs to be re-organized.

path for any problems with a task (the escalation path might be:
*troubleshooting procedure > Slack Channel > project Issue*). Get rid of the
[VReplication FAQ](https://vitess.io/docs/21.0/reference/vreplication/faq/)
in the reference section and put the information in a troubleshooting section.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you recommend consolidating everything into https://vitess.io/docs/faq/
And potentially renaming that to Troubleshooting?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepthi That's one possibility but there's more than troubleshooting information in the FAQ. See comment above re the FAQ. Let me look into it and I'll add some options to the recommendations.

Yes, there is a Community link in the site’s menu bar, leading to the Community page.

**New contributor document**: Is there a document specifically for new contributors/your
first contribution?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://vitess.io/docs/contributing/
That's for code contributions. Should we have a page for docs contributions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepthi Yes, or add doc contribution instructions to the code contribution doc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this file to analyses/0014-vitess/analysis.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwelsch-esi - please also rebase this PR from main at HEAD.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwelsch-esi - after you've rebased, also please ensure that all checks are passing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done the rebase @dwelsch-esi & @chalin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and the file rename)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to rebase again given the updates that have just landed for the link checking.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could you address the GH check failures?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just rebased again. I have to go do some mentorship stuff now, but I can check back in on this a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CNCFSD-2355] [Vitess] TechDocs Analysis & Website updates
4 participants