Use correct attribute type instead of package_type #17943
Conversation
|
|
|
Hi @NokiDev Thanks for your contribution. Lets start with the test that reproduces the issue first, as I have commented in #17942 (comment) |
NokiDev
changed the title
NokiDev
force-pushed
the
fix-wrong-property-usage-in-cmakedeps2
branch
from
fef0648 to
7777a0e
Compare
NokiDev
force-pushed
the
fix-wrong-property-usage-in-cmakedeps2
branch
from
7460a4b to
0a1c1ea
Compare
| @@ -81,13 +81,16 @@ def _requires(self, info, components): | |||
| assert required_pkg == required_comp | |||
| comp = None | |||
| default_target = f"{dep.ref.name}::{dep.ref.name}" # replace_requires | |||
| link = pkg_type is not PackageType.SHARED | |||
There was a problem hiding this comment.
In the test that I added, this movement is not necessary.
If this is necessary for a different use case, it would be great to have yet another test that covers this scenario.
There was a problem hiding this comment.
You're right this is triggered by another use case, see new test added. That triggers the first condition dep_comp == None, and then crash when evaluating the link.
For that case evaluating the link only on the package_type seems the simpler way to fix this one
There was a problem hiding this comment.
Ok, now with the test and the explanation is more clear, many thanks!
I have just fixed an indent error in the test, and CI is running.
Changelog: (Bugfix): _Component() has no package_type property #17942