-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward port arm64 patch from 14.x to 15.x #314
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13337499748. Examine the logs at this URL for more detail. |
Thanks Keith! 🙏 There are some linter fixes in PR: #271 Think we can backport those. Note these affect how GLIBC is configured. So we would want those even if there was no lint error |
a93831b
to
e98bb15
Compare
@conda-forge-admin, please rerender |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - I notice there's a bit of an offset in RuntimeDyldELF.cpp due to some other unrelated changes between 14 and 15, but the patching still succeeds:
checking file llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp
Hunk #1 succeeded at 2352 (offset 7 lines).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve again after the recently-pushed changes :-)
…nda-forge-pinning 2025.02.14.16.16.27
Thanks Keith and Graham! 🙏 Looks like we need this one too: #310 Would also add |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2025.02.14.20.50.03
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make the linter happy, please remove
llvmdev-feedstock/recipe/conda_build_config.yaml
Lines 6 to 7 in d93719d
MACOSX_SDK_VERSION: # [osx and x86_64] | |
- 10.12 # [osx and x86_64] |
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13348585909. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13337724912. Examine the logs at this URL for more detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this branch is really old, I cannot rule out that further fixes may be needed, but in any case, the changes here LGTM.
Thanks for your help @h-vetinari! |
No problem, thanks for the PR! Though I don't know which version llvmlite will move to next (thoughts @gmarkall?), we might want to fix this on the 16.x branch as well. AFAICT from looking at llvm/llvm-project#61402, the backport to 16.x never happened: https://github.com/llvm/llvm-project/blame/release/16.x/llvm/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp#L2408 At least it should be fixed as of v17. |
Yes, I'd agree it should be. I looked today at 16.0.6 and it wasn't applied, but it's present on 17.0.6. Even if Numba is not using it and may skipping it, any other user of LLVM on AArch64 can still be affected by the issue and suffer from segfaults. |
LLVM 15's lit tries to `import pipes`, which was removed in Python 3.11
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Looks like the osx build is using a system python instead of the environment python and getting a newer version than intended so |
You should be able to change llvmdev-feedstock/recipe/build.sh Line 74 in d93719d
to call the right python, e.g. $PREFIX/bin/python .
|
Done in #315 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Fixes #313