test: use flaky decorator for flaky OSX/Win tests #5623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
|
pre-commit.ci autofix |
beckermr
changed the title
beckermr
commented
Feb 16, 2025
|
@jaimergp can you take a look at this one? Hopefully it solves the random OSX/Win failures we've been seeing on recent PRs by simply retrying them. |
beckermr
changed the title
CodSpeed Performance ReportMerging #5623 will not alter performanceComparing Summary
|
|
I've rerun the tests several times to try and trigger any other random failures. I did not find any, so this PR is ready to go! |
isuruf
approved these changes
Feb 16, 2025
|
thanks @isuruf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
flakymark to some OSX/Win tests that fail at random. I am hoping it helps the test suite pass on the first try since retrying jobs takes a long time.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?