Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use flaky decorator for flaky OSX/Win tests #5623

Merged
merged 7 commits into from
Feb 16, 2025
Merged

test: use flaky decorator for flaky OSX/Win tests #5623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f0df91
test: use flaky decorator for flaky tests
beckermr Feb 16, 2025
af5d940
Fix typo in news file number for flaky tests
beckermr Feb 16, 2025
cac0156
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 16, 2025
ff78ebb
fix: need older pytest
beckermr Feb 16, 2025
1d05bc1
fix: use other package
beckermr Feb 16, 2025
b08d58c
Update news/5623-flaky-tests.rst
beckermr Feb 16, 2025
b1b5034
test: mark this one flaky too
beckermr Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions news/5623-flaky-tests.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Other

* Added the ``flaky`` mark for some OSX/Win tests that fail at random. (#5623)
3 changes: 3 additions & 0 deletions tests/test_api_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ def test_output_build_path_git_source(testing_config):

@pytest.mark.sanity
@pytest.mark.serial
@pytest.mark.flaky(reruns=5, reruns_delay=2)
def test_build_with_no_activate_does_not_activate():
api.build(
os.path.join(metadata_dir, "_set_env_var_no_activate_build"),
Expand Down Expand Up @@ -474,6 +475,7 @@ def test_build_msvc_compiler(msvc_ver, monkeypatch):
@pytest.mark.sanity
@pytest.mark.parametrize("platform", platforms)
@pytest.mark.parametrize("target_compiler", compilers)
@pytest.mark.flaky(reruns=5, reruns_delay=2)
def test_cmake_generator(platform, target_compiler, testing_config):
testing_config.variant["python"] = target_compiler
testing_config.activate = True
Expand Down Expand Up @@ -1791,6 +1793,7 @@ def test_overlinking_detection_ignore_patterns(
rm_rf(dest_bat)


@pytest.mark.flaky(reruns=5, reruns_delay=2)
def test_overdepending_detection(testing_config, variants_conda_build_sysroot):
testing_config.activate = True
testing_config.error_overlinking = True
Expand Down
Loading