Fix lief #5627
Open
Fix lief #5627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @bernt-matthias. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1114), and ping the bot to refresh the PR. |
followup on conda#5595 fixes conda#5626 in lief 0.15 not only the classes were renamed but also enum members: lief-project/LIEF@cddd8dd#diff-88d5303887e96766711bd8ff242b652c29bc0ee0fa3ef8004bfc797c9a23040b latest version here: https://github.com/lief-project/LIEF/blob/0e5db4ea906b3252653dd90c627f8462d7e39ba4/api/python/lief/ELF/__init__.pyi#L2037
bernt-matthias
force-pushed
the
fix-lief-elf
branch
from
a27e21e to
477adee
Compare
tkelman
reviewed
Feb 21, 2025
conda_build/os_utils/liefldd.py
Outdated
| except AttributeError: | ||
| # Fallback for lief<0.15. | ||
| ELF_CLASS = lief.ELF.ELF_CLASS | ||
| ELF64 = lief.ELF.ELF64 |
There was a problem hiding this comment.
the ELF64 name wasn't used in lief prior to 0.15, was it? should this line be
ELF64 = lief.ELF.ELF_CLASS.CLASS64 ?
There was a problem hiding this comment.
Indeed. Copy paste / search replace error :)
|
@conda-bot check |
conda-bot
added
the
cla-signed
bernt-matthias
commented
Feb 21, 2025
CodSpeed Performance ReportMerging #5627 will not alter performanceComparing Summary
|
5 tasks
Merged
5 tasks
|
Anything I can do here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
followup on #5595 fixes #5626
targeted 25.1.x because #5595 seems not yet merged to main
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?