Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin back lief even more for conda-build #966

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

beckermr
Copy link
Member

@beckermr beckermr commented Feb 23, 2025

Checklist

  • Used a static YAML file for the patch if possible (instructions).
  • Only wrote code directly into generate_patch_json.py if absolutely necessary.
  • Ran pre-commit run -a and ensured all files pass the linting checks.
  • Ran python show_diff.py and posted the output as part of the PR.
  • Modifications won't affect packages built in the future.

There is still an open conda-build issue for lief 0.15, so pin back even more.

xref: conda/conda-build#5627

@beckermr beckermr requested a review from a team as a code owner February 23, 2025 11:57
@beckermr beckermr changed the title fix: pin back even more fix: pin back lief even more for conda-build Feb 23, 2025
@beckermr beckermr added the automerge Merge the PR when CI passes label Feb 23, 2025
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@beckermr beckermr mentioned this pull request Feb 23, 2025
5 tasks
@conda-forge-admin conda-forge-admin merged commit 5582ab8 into conda-forge:main Feb 23, 2025
3 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • github-actions: passed

Thus the PR was passing and merged! Have a great day!

@beckermr beckermr deleted the beckermr-patch-6 branch February 23, 2025 12:12
@maresb
Copy link
Contributor

maresb commented Feb 23, 2025

@beckermr, this doesn't fix it yet, since py-lief 0.16.2 is in quay.io/condaforge/linux-anvil-x86_64:alma9:

docker run --rm -it quay.io/condaforge/linux-anvil-x86_64:alma9 micromamba list py-lief
List of packages in environment: "/opt/conda"

  Name     Version  Build            Channel    
──────────────────────────────────────────────────
  py-lief  0.16.2   py312h2ec8cdc_0  conda-forge

The command in the runner:

micromamba install --root-prefix /home/conda/.conda --prefix /opt/conda --yes --override-channels --channel conda-forge --strict-channel-priority pip python=3.12 conda-build conda-forge-ci-setup=4 'conda-build>=24.1'

doesn't pick up the new repodata patch.

See for example conda-forge/mkl-service-feedstock#38

@beckermr
Copy link
Member Author

Ouch. We'll need to rebuild the docker images. I am away from my keyboard, so feel free to go ahead and submit a pr. Otherwise I can do it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants