correct extra files ref issue introduced in 0c80f9b #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @NixM0nk3y. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#1117), and ping the bot to refresh the PR. |
jaimergp
reviewed
Feb 28, 2025
|
|
||
| ### Bug fixes | ||
|
|
||
| * Fix extra_file functionality on exe installers. (#942) |
There was a problem hiding this comment.
Suggested change
| * Fix extra_file functionality on exe installers. (#942) | |
| * Fix `extra_files` functionality on EXE installers. (#942) |
|
Hm, I wonder why the tests didn't catch that if that's indeed the bug 🤔 Let's see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building windows installers using the latest version of constructor (3.11.1) has broken
extra_files. Reverting to 3.11.0 solves the issues. This looks to have been introduced in 0c80f9b with the recent jinga changes and the casing of the extra_files var was changed.Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?