Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct extra files ref issue introduced in 0c80f9b #942

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −1
Open

correct extra files ref issue introduced in 0c80f9b #942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2bec9b
correct extra files ref issue introduced in 0c80f9b
Feb 25, 2025
38185ef
update news
Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion constructor/nsis/main.nsi.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,7 +1265,7 @@ Section "Install"
File {{ conda_exe }}
File {{ pre_uninstall }}

{%- for path, files in extra_files | items %}
{%- for path, files in EXTRA_FILES | items %}
SetOutPath {{ path }}
{%- for file in files %}
File {{ file }}
Expand Down
19 changes: 19 additions & 0 deletions news/942-fix-win-extra_files
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Enhancements

* <news item>

### Bug fixes

* Fix extra_file functionality on exe installers. (#942)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fix extra_file functionality on exe installers. (#942)
* Fix `extra_files` functionality on EXE installers. (#942)


### Deprecations

* <news item>

### Docs

* <news item>

### Other

* <news item>
Loading