Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump release to 5.4.0.1 #517

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

inknos
Copy link
Contributor

@inknos inknos commented Feb 19, 2025

The podman pyproject.toml was updated to fix a packaging issue that prevented the import podman.api to work.

This caused an issue in the package versioning. Python-podman cannot be bumped to version 5.4.1 since it will try to use the libpod/v5.4.1/ endpoint which is not released yet. Python-podman uses the same versioning scheme and so the package need to add a fourth digi in the version scheme to be released on PyPI. This can be avoided in distribution packages with the option of a new release or a patch downstream, but on GitHub and PyPI this is the workaround.

Source for packaging Python software
https://packaging.python.org/en/latest/specifications/version-specifiers/#version-specifiers

The podman pyproject.toml was updated to fix a packaging issue that
prevented the `import podman.api` to work.

This caused an issue in the package versioning. Python-podman cannot be
bumped to version 5.4.1 since it will try to use the libpod/v5.4.1/
endpoint which is not released yet. Python-podman uses the same
versioning scheme and so the package need to add a fourth digi in the
version scheme to be released on PyPI. This can be avoided in
distribution packages with the option of a new release or a patch
downstream, but on GitHub and PyPI this is the workaround.

Source for packaging Python software
https://packaging.python.org/en/latest/specifications/version-specifiers/#version-specifiers

Signed-off-by: Nicola Sella <nsella@redhat.com>
@inknos inknos mentioned this pull request Feb 19, 2025
Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given packit jobs are successful.

@jwhonce @baude @rhatdan PTAL.

Copy link

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

@Gauravtalreja1: changing LGTM is restricted to collaborators

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Feb 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gauravtalreja1, inknos, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwhonce
Copy link
Member

jwhonce commented Feb 19, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 19, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2a29132 into containers:main Feb 19, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants