async stuff #11
Open
async stuff #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2017 13:48
scopatz
reviewed
Nov 1, 2017
rickshaw/node_server.py
Outdated
| from asyncio.subprocess import create_subprocess_exec | ||
| from argparse import ArgumentParser | ||
|
|
||
| def make_parser(): |
There was a problem hiding this comment.
PEP8 two blank lines before functions. All throughout this file
scopatz
reviewed
Nov 1, 2017
rickshaw/node_server.py
Outdated
| pending_tasks.append(sim_task) | ||
| i += 1 | ||
| if len(pending_tasks) > 0: | ||
| done, pending_tasks = await asyncio.wait(pending_tasks, return_when=concurrent.futures.FIRST_COMPLETED) |
|
Generally looks good, but we probably also need some docs for this. Also, maybe we should remove doctr for the PR here and we should probably run the actual tests on circleci |
|
Maybe CI should be in a different PR though? |
|
Yeah, CI should probably go in a separate PR. Documentation is the right call though. |
|
Ok, let me know when it is added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.