-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async stuff #11
Open
FlanFlanagan
wants to merge
2
commits into
cyclus:master
Choose a base branch
from
FlanFlanagan:node_serv
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
async stuff #11
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
"""Asynchonous job creation for rickshaw for use on HPC systems.""" | ||
|
||
import asyncio | ||
import concurrent.futures | ||
from asyncio.subprocess import create_subprocess_exec | ||
from argparse import ArgumentParser | ||
|
||
def make_parser(): | ||
"""Makes the argument parser for the rickshaw node server.""" | ||
p = ArgumentParser("rickshaw-node-server", description="Rickshaw Node Server CLI") | ||
p.add_argument("--debug", action='store_true', default=False, | ||
dest='debug', help="runs the server in debug mode.") | ||
p.add_argument("-p", "--nproc", type=int, default=1, dest="nproc", | ||
help="Number of processes") | ||
p.add_argument("-s", "--nsim", type=int, default=1, dest="nsim", | ||
help="Number of simulations to run") | ||
p.add_argument("-n", "--name", type=str, default="cyclus", dest="name", | ||
help="Node name") | ||
p.add_argument("-f", "--format", type=str, default="h5", dest="format", | ||
help="The format of output file, h5 or sqlite") | ||
return p | ||
|
||
async def run_sim(output_q, filename): | ||
inputfile = "" | ||
p = await create_subprocess_exec("cyclus", "-o", filename, "-i", inputfile) | ||
await p.wait() | ||
await output_q.put(filename) | ||
|
||
async def run_sims(output_q, nsim): | ||
i = 0 | ||
pending_tasks = [] | ||
while i < nsim: | ||
while not output_q.empty() and i < nsim: | ||
filename = await output_q.get() | ||
sim_task = asyncio.ensure_future(run_sim(output_q, filename)) | ||
pending_tasks.append(sim_task) | ||
i += 1 | ||
if len(pending_tasks) > 0: | ||
done, pending_tasks = await asyncio.wait(pending_tasks, return_when=concurrent.futures.FIRST_COMPLETED) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PEP8 line over 80 chars |
||
pending_tasks = list(pending_tasks) | ||
if len(pending_tasks) > 0: | ||
await asyncio.wait(pending_tasks) | ||
|
||
def main(args=None): | ||
p = make_parser() | ||
ns = p.parse_args(args=args) | ||
executor = concurrent.futures.ThreadPoolExecutor(max_workers=ns.nproc) | ||
loop = asyncio.get_event_loop() | ||
output_q = asyncio.Queue() | ||
for i in range(ns.nproc): | ||
output_q.put_nowait("{name}-{i:03}.{format}".format(name=ns.name, i=i, format=ns.format)) | ||
if ns.debug: | ||
loop.set_debug(True) | ||
try: | ||
loop.run_until_complete(run_sims(output_q, ns.nsim)) | ||
finally: | ||
if not loop.is_closed(): | ||
loop.close() | ||
|
||
if __name__ == '__main__': | ||
main() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEP8 two blank lines before functions. All throughout this file