Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Cleanup and enforce types check #1102

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

mattrunyon
Copy link
Collaborator

Was going through actions to figure out where to add docs PR previews and saw this type check action was not part of the enforced tests, missing setup-node (so not sure what version it was using), and adding functionality that setup-node already provides (matchers for tsc and eslint errors in logs).

I added JS build to the test-js-packages step. This isn't completely necessary since the e2e job should fail if the packages fail to build, but figured an explicit check was good to add.

@mattrunyon mattrunyon requested a review from a team January 31, 2025 00:19
@mattrunyon mattrunyon self-assigned this Jan 31, 2025
@mattrunyon mattrunyon requested review from bmingles and removed request for a team January 31, 2025 00:19
@@ -48,7 +48,7 @@ export class PlotlyExpressChartModel extends ChartModel {
) {
super(dh);

this.widget = widget;
this.widget = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattrunyon Was this left here intentionally?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I did it to test that the CI test actually fails. Turns out I broke CI because it runs npm run build -- --scope <plugin> and I changed the build script at the root. I'll fix that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I wanted to see which was what the Python file was doing before. It's built-in to the setup-node action.

image

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments

@mattrunyon mattrunyon requested a review from bmingles January 31, 2025 18:30
@mattrunyon
Copy link
Collaborator Author

I also added fail-fast: false to our matrix testing. I can move that to a separate PR if you want. It just makes it easier to see what the errors are because a bunch of in-progress jobs would get stopped with the default fal-fast: true. So it made it hard to determine if it's a Python version-specific issue, general Python issue, etc. This way the tests will run for all versions in the matrix regardless of the outcome of the others.

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrunyon mattrunyon merged commit d7b2ae3 into deephaven:main Feb 7, 2025
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants