ci: Cleanup and enforce types check

.github/workflows/modified-plugin.yml

@@ -59,6 +59,7 @@ jobs:
     needs: changes
     if: ${{ needs.changes.outputs.packages != '[]' && needs.changes.outputs.packages != '' }}
     strategy:
+      fail-fast: false
       matrix:
         package: ${{ fromJSON(needs.changes.outputs.packages) }}
     uses: ./.github/workflows/test-python-package.yml
@@ -108,6 +109,7 @@ jobs:
     # Only build main docs for push on main branch and PRs to main
     if: ${{ needs.changes.outputs.packages != '[]' && needs.changes.outputs.packages != '' && (github.ref == 'refs/heads/main' || github.base_ref == 'main') && (github.event_name == 'push' || github.event_name == 'pull_request')}}
     strategy:
+      fail-fast: false
       matrix:
         package: ${{ fromJSON(needs.changes.outputs.packages) }}
     uses: ./.github/workflows/build-main-docs.yml

.github/workflows/test-js-packages.yml

@@ -55,10 +55,18 @@ jobs:
         if: steps.restore-node-modules.outputs.cache-hit != 'true'
         run: npm ci --no-audit
 
+      - name: Build check
+        run: npm run build
+
+      - name: Type check
+        if: always() # Can still run types even if the build fails
+        run: npm run types
+
       # Run all tests for all the packages
       # Caching with the absolute path b/c Jest will make a folder in each project
       # Then there's caches in all plugin folders
       - name: Run Tests
+        if: always() # Can still run jest tests even if the build/types fail
         run: npm run test:ci
 
       - name: Always cache node modules

.github/workflows/test-python-package.yml

@@ -11,6 +11,7 @@ jobs:
   test:
     runs-on: ubuntu-22.04
     strategy:
+      fail-fast: false
       matrix:
         python: ['3.8', '3.9', '3.10', '3.11', '3.12']
     steps:

package.json

@@ -9,7 +9,8 @@
     "docker": "docker compose up deephaven-plugins --build",
     "start": "run-p \"start:packages -- {@}\" serve:plugins --",
     "build": "lerna run build --stream",
-    "watch:types": "tsc -p . --watch --emitDeclarationOnly false --noEmit",
+    "types": "tsc",
+    "watch:types": "tsc --watch",
     "serve:plugins": "vite",
     "start:packages": "lerna run start --stream",
     "test": "jest --watch --changedSince origin/main",

plugins/example-theme/src/js/package.json

@@ -5,7 +5,7 @@
   "main": "dist/index.js",
   "scripts": {
     "dev": "vite",
-    "build": "tsc && vite build",
+    "build": "vite build",
     "preview": "vite preview",
     "start": "npm run build -- -w",
     "update-dh-packages": "node ../../../../tools/update-dh-packages.mjs"

plugins/plotly-express/src/js/package.json

@@ -32,7 +32,7 @@
   "homepage": "https://github.com/deephaven/deephaven-plugins",
   "scripts": {
     "start": "vite build --watch",
-    "build": "tsc && vite build",
+    "build": "vite build",
     "update-dh-packages": "node ../../../../tools/update-dh-packages.mjs"
   },
   "devDependencies": {

tsconfig.json

@@ -1,5 +1,9 @@
 {
   "extends": "@deephaven/tsconfig",
+  "compilerOptions": {
+    "emitDeclarationOnly": false,
+    "noEmit": true
+  },
   "include": [
     "plugins/**/**.ts",
     "plugins/**/**.tsx",