System.Formats.Cbor.Tests.DataModel: don't sign when DotNetBuildSourceOnly. #111123
Conversation
dotnet-policy-service
bot
added
the
community-contribution
|
I validated this fixes the issue we see in our internal CI. |
| @@ -4,6 +4,8 @@ | |||
| <TargetFramework>$(NetCoreAppCurrent)</TargetFramework> | |||
| <!-- NuGet restore issue with TargetFrameworks in f# projects: https://github.com/NuGet/Home/issues/10005 --> | |||
| <TargetFramework>$(NetCoreAppCurrent)</TargetFramework> | |||
| <!-- Public signing (performed under DotNetBuildSourceOnly) is broken for f#: https://github.com/dotnet/fsharp/issues/17451 --> | |||
| <SignAssembly Condition="'$(DotNetBuildSourceOnly)' == 'true'">false</SignAssembly> | |||
There was a problem hiding this comment.
Wouldn't it make more sense to apply this to all fsproj files from a shared rule, and then remove it from the shared rule when the signing bug is fixed?
e.g. a rule that looks at the project file extension in a dirs.props or dirs.targets?
There was a problem hiding this comment.
If we want to apply this more general, we should probably do it in arcade ProjectDefaults.props.
This is a workaround for just this project (which seems to be the only affected).
@ViktorHofer @mmitche what is your preference?
There was a problem hiding this comment.
Agreed. Please make the change in Arcade, probably under Workaround.targets.
|
Closing in favor of dotnet/arcade#15380. |
|
I'm re-opening this because the attempt to generally tackle this in arcade failed, see dotnet/arcade#15420. I would prefer to make this change rather than try to add more complex logic to arcade. |
|
There's already a tracking issue for the failing test: #111460. Not sure why BuildAnalysis doesn't see it. /ba-g ignore |
Fixes #111117.
@ViktorHofer @vcsjones ptal.
cc @mmitche @omajid