Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Formats.Cbor.Tests.DataModel: don't sign when DotNetBuildSourceOnly. #111123

Merged
merged 2 commits into from
Jan 16, 2025
Merged

System.Formats.Cbor.Tests.DataModel: don't sign when DotNetBuildSourceOnly. #111123

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ed3dac
System.Formats.Cbor.Tests.DataModel: don't sign when DotNetBuildSourc…
tmds Jan 6, 2025
4d57cfe
Merge branch 'main' into skip_sign
ViktorHofer Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...braries/System.Formats.Cbor/tests/CborDocument/System.Formats.Cbor.Tests.DataModel.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
<!-- NuGet restore issue with TargetFrameworks in f# projects: https://github.com/NuGet/Home/issues/10005 -->
<TargetFramework>$(NetCoreAppCurrent)</TargetFramework>
<!-- Public signing (performed under DotNetBuildSourceOnly) is broken for f#: https://github.com/dotnet/fsharp/issues/17451 -->
<SignAssembly Condition="'$(DotNetBuildSourceOnly)' == 'true'">false</SignAssembly>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make more sense to apply this to all fsproj files from a shared rule, and then remove it from the shared rule when the signing bug is fixed?

e.g. a rule that looks at the project file extension in a dirs.props or dirs.targets?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to apply this more general, we should probably do it in arcade ProjectDefaults.props.

This is a workaround for just this project (which seems to be the only affected).

@ViktorHofer @mmitche what is your preference?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Please make the change in Arcade, probably under Workaround.targets.

</PropertyGroup>

<ItemGroup>
Expand Down
Loading