update aws-java-sdk to 1.10.67 #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmgreaves
commented
Apr 6, 2016
malcolmgreaves
commented
- Patch update on the aws-java-sdk dependency. Includes bug fixes, one of them is related to XML parsing of the S3 request when there are weird or otherwise non-standard characters in the object filenames.
- Updated sns.scala's and sqs.scala's many invocations of wrapVoidAsyncMethod and wrapAsyncMethod
- added explicit type parameters
- this is so that the compilier can differentiate between the various client.xxx methods
- Updated aws-jdk-sdk has additional invocations for each original client.xxx method
- added explicit type parameters
- These code changes, while trivial, resulted in verbose, long code. To keep with styling conventions, I dropped the parameters for the wrapAsync* method invocations to separate new-lines.
* Patch update on the aws-java-sdk dependency. Includes bug fixes, one of them is related to XML parsing of the S3 request when there are weird or otherwise non-standard characters in the object filenames.
* Updated sns.scala's and sqs.scala's many invocations of wrapVoidAsyncMethod and wrapAsyncMethod
* added explicit type parameters
* this is so that the compilier can differentiate between the various client.xxx methods
* Updated aws-jdk-sdk has additional invocations for each original client.xxx method
* These code changes, while trivial, resulted in verbose, long code. To keep with styling conventions, I dropped the parameters for the wrapAsync* method invocations to separate new-lines.
|
Requesting review please @dwhjames |
|
@malcolmgreaves |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.