Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22666] Fix CI windows vcpkg installation lz4 zstd #175

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

EugenioCollado
Copy link
Contributor

The record&replay CI is currently failing on action install_mcap_dependencies in windows in step Install vcpkg

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.34%. Comparing base (b933de7) to head (1670218).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   25.24%   26.34%   +1.09%     
==========================================
  Files          75       56      -19     
  Lines        5843     3671    -2172     
  Branches     2999     1811    -1188     
==========================================
- Hits         1475      967     -508     
+ Misses       3398     2030    -1368     
+ Partials      970      674     -296     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EugenioCollado EugenioCollado force-pushed the fix/CI_vcpkg branch 2 times, most recently from 46fb459 to 4dd4c21 Compare January 23, 2025 15:59
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit 3d12b04 into main Jan 24, 2025
16 of 19 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the fix/CI_vcpkg branch January 24, 2025 07:14
@EugenioCollado
Copy link
Contributor Author

@Mergifyio backport 0.x

Copy link

mergify bot commented Jan 27, 2025

backport 0.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 27, 2025
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
(cherry picked from commit 3d12b04)
juanlofer-eprosima pushed a commit that referenced this pull request Jan 27, 2025
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
(cherry picked from commit 3d12b04)

Co-authored-by: EugenioCollado <121509066+EugenioCollado@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants