-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22666] Fix CI windows vcpkg installation lz4 zstd #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugenioCollado
temporarily deployed
to
codecov
January 23, 2025 15:12 — with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 25.24% 26.34% +1.09%
==========================================
Files 75 56 -19
Lines 5843 3671 -2172
Branches 2999 1811 -1188
==========================================
- Hits 1475 967 -508
+ Misses 3398 2030 -1368
+ Partials 970 674 -296 ☔ View full report in Codecov by Sentry. |
EugenioCollado
force-pushed
the
fix/CI_vcpkg
branch
2 times, most recently
from
January 23, 2025 15:59
46fb459
to
4dd4c21
Compare
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
EugenioCollado
force-pushed
the
fix/CI_vcpkg
branch
from
January 24, 2025 06:48
4dd4c21
to
1670218
Compare
EugenioCollado
temporarily deployed
to
codecov
January 24, 2025 06:48 — with
GitHub Actions
Inactive
juanlofer-eprosima
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport 0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 27, 2025
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com> (cherry picked from commit 3d12b04)
juanlofer-eprosima
pushed a commit
that referenced
this pull request
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The record&replay CI is currently failing on action install_mcap_dependencies in windows in step Install vcpkg