BUGFIX/HCMPRE-2253 : Fixed Button Issue in PopDataTable Screen

[Swathi-eGov]

Choose the appropriate template for your PR:

Feature PR

Feature Request

JIRA ID

Module

Description

Related Issues

---

Bugfix PR

Bugfix Request

JIRA ID

Module

Description

Root Cause

Related Issues

---

Release PR

Summary by CodeRabbit

• New Features
  • Alerts now offer enhanced SVG rendering for a sharper visual experience.
  • The inbox automatically refreshes status counts after workflow actions, ensuring up-to-date information is displayed.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change introduces a new boolean property, showAlertAsSvg, in the PopUp component within the BoundarySelection component to enable SVG display for alerts. Additionally, a call to the fetchStatusCount() function is added in the onSuccess callback of the WorkflowCommentPopUp component in PopInbox.js, ensuring the UI reflects updated status counts after workflow updates.

Changes

File(s)	Change Summary
.../components/BoundarySelection.js	Added a new property showAlertAsSvg (set to true) in the PopUp component within the BoundarySelection component.
.../pages/employee/PopInbox.js	Inserted a call to fetchStatusCount() in the onSuccess callback of the WorkflowCommentPopUp component to refresh status counts after a workflow operation.

Sequence Diagram(s)

sequenceDiagram
    participant PopInbox as PopInbox Component
    participant Workflow as WorkflowCommentPopUp
    participant StatusAPI as fetchStatusCount Function

    Workflow->>PopInbox: onSuccess Event
    PopInbox->>StatusAPI: Call fetchStatusCount()
    StatusAPI-->>PopInbox: Return updated status count
    PopInbox->>Workflow: Render updated count

Loading

Possibly related PRs

• added popup for boundary summary #1525: Modifications involving the PopUp component in the BoundaryDetailsSummary which share similarities with the current changes.
• Popup fix #1958: Adjustments to the PopUp properties in the UserAccess component, presenting a direct connection to the modifications in this PR.

Suggested reviewers

• nabeelmd-eGov
• jagankumar-egov

Poem

I'm a little rabbit with code in my paws,
Hoping these changes get a round of applause.
SVG alerts now dance in view,
While status counts freshen up the cue.
With hops and cheers, I'll code anew!
🐰✨

Tip

🌐 Web search-backed reviews and chat

• We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
• You can disable this feature by setting web_search: false in the knowledge_base settings.
• Please share any feedback in the Discord discussion.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🔭 Outside diff range comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

13-875: Consider breaking down this large component for better maintainability.

The PopInbox component has grown quite large and handles multiple responsibilities. Consider:

1. Extracting workflow management logic into a custom hook (e.g., useWorkflowManagement).
2. Creating separate components for the filter section and action buttons.
3. Moving status tracking logic into a dedicated hook (e.g., useStatusTracking).

This would improve code organization, reusability, and testing.

🧰 Tools

🪛 Biome (1.9.4)

[error] 151-151: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

[error] 204-204: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

---

[error] 272-272: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

---

[error] 324-324: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

---

[error] 357-357: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

---

[error] 377-377: Unnecessary use of boolean literals in conditional expression.

Simplify your code by directly assigning the result without using a ternary operator.
If your goal is negation, you may use the logical NOT (!) or double NOT (!!) operator for clearer and concise code.
Check for more details about NOT operator.
Unsafe fix: Remove the conditional expression with

(lint/complexity/noUselessTernary)

---

[error] 642-648: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.

Unsafe fix: Use a SelfClosingElement instead

(lint/style/useSelfClosingElements)

---

[error] 687-687: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.

Unsafe fix: Use a SelfClosingElement instead

(lint/style/useSelfClosingElements)

---

[error] 141-141: Use Number.POSITIVE_INFINITY instead of the equivalent global.

ES2015 moved some globals into the Number namespace for consistency.
Safe fix: Use Number.POSITIVE_INFINITY instead.

(lint/style/useNumberNamespace)

---

[error] 819-819: Missing key property for this element in iterable.

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

(lint/correctness/useJsxKeyInIterable)

---

[error] 831-833: Missing key property for this element in iterable.

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

(lint/correctness/useJsxKeyInIterable)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2414a37 and 2b21c1c.

📒 Files selected for processing (2)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.js`: check

**/*.js: check

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js

📓 Learnings (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (2)

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1837
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js:559-561
Timestamp: 2024-11-15T10:15:57.370Z
Learning: In `PopInbox.js`, error handling for the `onError` callback in `WorkflowCommentPopUp` is handled within the component, so explicit error handling in the parent component is unnecessary.

Learnt from: rachana-egov
PR: egovernments/DIGIT-Frontend#1832
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js:592-594
Timestamp: 2024-11-14T12:48:23.024Z
Learning: In `PopInbox.js`, when integrating the `ConfirmationPopUp` component, error handling for API failures is managed internally within the component, so explicitly passing an `onError` prop is not necessary.

🔇 Additional comments (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

792-792: LGTM! Good addition for data consistency.

The addition of fetchStatusCount() in the onSuccess callback ensures that status counts are refreshed after a successful workflow update, maintaining UI consistency.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/BoundarySelection.js (1)

116-151: Verify PopUp component's SVG support.

The PopUp component is used here to display important boundary-related warnings. Let's verify that the component properly supports SVG alerts.

Also, let's verify the component's documentation:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Search for PopUp component definition to verify SVG alert support
ast-grep --pattern 'const PopUp = ({ showAlertAsSvg, $$$}) => {
  $$$
}'

Length of output: 74

---

🌐 Web query:

What are the supported props for egovernments digit-ui-components PopUp component?

💡 Result:

The `PopUp` component from `@egovernments/digit-ui-components` supports **two primary variants** (`default` and `alert`) based on its July 2024 update[7]. While detailed prop documentation isn’t explicitly provided in the search results, typical React component patterns suggest additional common props likely exist:

**Confirmed Props:**
- `variant`: Specifies visual style (`"default"` or `"alert"`)[7][9].

**Inferred Props (common patterns):**
- `isOpen`: Boolean to control visibility.
- `onClose`: Callback triggered when closing.
- `children`: Content rendered inside.
- `title`: Header text.
- `actions`: Buttons/CTAs (e.g., Confirm/Cancel).

For exact implementation details or advanced configurations (e.g., custom styling hooks), refer to DIGIT’s Storybook documentation[4][6].

Citations:

- 1: https://core.digit.org/guides/developer-guide/ui-developer-guide/digit-ui
- 2: https://sanitation.digit.org/setup/development-guide/ui-developer-guide
- 3: https://docs.apryse.com/web/guides/modular-ui/items
- 4: https://github.com/egovernments/DIGIT-UI-LIBRARIES/tree/master
- 5: https://www.npmjs.com/package/@egovernments/digit-ui-react-components
- 6: https://github.com/egovernments/DIGIT-Frontend
- 7: https://www.npmjs.com/package/@egovernments/digit-ui-components
- 8: https://urban.digit.org/v2.6/product/modules/hrms/employee-activation-deactivation-ui-flow
- 9: https://www.npmjs.com/package/@egovernments/digit-ui-components-css
- 10: https://www.digitalpublicgoods.net/r/digit

---

🏁 Script executed:

#!/bin/bash
# Search the entire repository for references to "showAlertAsSvg"
rg -n "showAlertAsSvg"

Length of output: 160

---

Verified: PopUp component's SVG support appears to be correctly enabled in this usage.

• The code in BoundarySelection.js passes showAlertAsSvg={true} when using the PopUp component.
• While the AST search didn’t return the internal implementation (likely because PopUp is imported from an external library), the external documentation confirms that the component supports an alert variant which is consistent with SVG-enabled alerts.
• No contradictory evidence was found regarding the support for SVG alerts.

🧰 Tools

🪛 Biome (1.9.4)

[error] 117-150: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.

Unsafe fix: Use a SelfClosingElement instead

(lint/style/useSelfClosingElements)

---

[error] 136-147: Missing key property for this element in iterable.

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

(lint/correctness/useJsxKeyInIterable)