feat: replace multierror with stdlib errors wrapping #41043
Conversation
replace multierror library with stdlib error wrapping
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
|
mergify
bot
added
the
backport-8.x
|
@kruskall can we also remove the use of "github.com/pkg/errors"? |
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
| @@ -108,8 +108,7 @@ func (lo *IPv6Loopback) AddRandomAddress() (addr net.IP, err error) { | |||
| if err = unix.Bind(fd, &bindAddr); err == nil { | |||
| break | |||
| } | |||
| //nolint:errorlint // ignore | |||
| if errno, ok := err.(unix.Errno); !ok || errno != unix.EADDRNOTAVAIL { | |||
| if !errors.Is(err, unix.EADDRNOTAVAIL) { | |||
There was a problem hiding this comment.
:old-man-shouting-at-clouds: x/sys/unix has two instances of %w (both in code generators rather than lib code) and AFAICS no other form of error wrapping (it would be very strange if a package that sits at this level of the stack did). While not bound by go1compat or semver, it would be extremely surprising if this ever changed since code is copied from x/sys/unix into the std tree. But if it keeps people happy…
kruskall
force-pushed
the
feat/drop-multierror
branch
from
a5717bb to
31eaecc
Compare
|
@elastic/app-search-team @elastic/obs-infraobs-integrations @elastic/stack-monitoring friendly ping for review 🙂 |
| entryValues := v.Value.(map[string]interface{}) | ||
| constructEvents(entryValues, v, mbeanEvents, mapping, errs) | ||
| entryValues, ok := v.Value.(map[string]interface{}) | ||
| if ok { |
There was a problem hiding this comment.
Not my code to say so either way, but I wonder if this needs an else to add an error?
Proposed commit message
replace multierror library with stdlib error wrapping
Go 1.20 added errors.Join allowing for multierrors. Replace go-multierror usage with native go errors
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs