Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace multierror with stdlib errors wrapping #41043

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
fef0a58
feat: replace multierror with stdlib errors wrapping
kruskall Sep 29, 2024
3f9dd7f
lint: fix linting issues
kruskall Sep 29, 2024
6e3cc29
lint: regenerate notice file
kruskall Sep 29, 2024
8d389db
lint: fix linting issues
kruskall Sep 29, 2024
6053d69
lint: fix linting issues
kruskall Sep 29, 2024
4b9416c
lint: fix linting issues
kruskall Sep 29, 2024
6214d97
lint: fix linting issues
kruskall Sep 29, 2024
1511c5e
lint: fix linting issues
kruskall Sep 29, 2024
54c663f
lint: fix linting issues
kruskall Sep 29, 2024
c5a3b9a
lint: fix linting issues
kruskall Sep 30, 2024
712d258
lint: fix linting issues
kruskall Sep 30, 2024
eacde97
lint: fix linting issues
kruskall Sep 30, 2024
88f930b
Merge branch 'main' into feat/drop-multierror
kruskall Sep 30, 2024
b3f3c10
Update auditbeat/module/auditd/config.go
kruskall Oct 1, 2024
6c92592
Update auditbeat/module/file_integrity/config_test.go
kruskall Oct 1, 2024
ac27fd4
lint: merge lines
kruskall Oct 1, 2024
777fada
lint: fix linter issues
kruskall Oct 1, 2024
0437395
lint: fix linter issues
kruskall Oct 1, 2024
794432e
lint: fix linter issues
kruskall Oct 1, 2024
d6debe0
Merge branch 'main' into feat/drop-multierror
kruskall Oct 6, 2024
c84a4bc
lint: rename errs variable
kruskall Oct 6, 2024
f429777
fix: update wrapping format
kruskall Oct 7, 2024
c686027
lint: go mod tidy
kruskall Oct 7, 2024
31eaecc
Merge remote-tracking branch 'upstream/main' into feat/drop-multierror
kruskall Nov 26, 2024
36604e1
Merge branch 'main' into feat/drop-multierror
kruskall Dec 4, 2024
806c386
Merge branch 'main' into feat/drop-multierror
kruskall Dec 10, 2024
a302435
Merge remote-tracking branch 'upstream/main' into feat/drop-multierror
kruskall Dec 11, 2024
0703f87
Merge branch 'main' into feat/drop-multierror
kruskall Dec 14, 2024
6f9de17
Merge branch 'main' into feat/drop-multierror
kruskall Dec 20, 2024
7eee277
Merge branch 'main' into feat/drop-multierror
kruskall Jan 22, 2025
cf0f766
feat: remove new usage
kruskall Jan 22, 2025
b06b8dc
Update wineventlog.go
kruskall Jan 24, 2025
b90820c
Merge branch 'main' into feat/drop-multierror
kruskall Jan 24, 2025
9f58d8b
Merge remote-tracking branch 'upstream/main' into feat/drop-multierror
kruskall Mar 5, 2025
387365a
Merge branch 'main' into feat/drop-multierror
kruskall Mar 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/auditbeat/module/system/socket/helper/loopback.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,7 @@ func (lo *IPv6Loopback) AddRandomAddress() (addr net.IP, err error) {
if err = unix.Bind(fd, &bindAddr); err == nil {
break
}
//nolint:errorlint // ignore
if errno, ok := err.(unix.Errno); !ok || errno != unix.EADDRNOTAVAIL {
if !errors.Is(err, unix.EADDRNOTAVAIL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:old-man-shouting-at-clouds: x/sys/unix has two instances of %w (both in code generators rather than lib code) and AFAICS no other form of error wrapping (it would be very strange if a package that sits at this level of the stack did). While not bound by go1compat or semver, it would be extremely surprising if this ever changed since code is copied from x/sys/unix into the std tree. But if it keeps people happy…

break
}
time.Sleep(time.Millisecond * time.Duration(i))
Expand Down