-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Netflow code to the logp logging library #42270
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
just curious - why is this PR to branch |
I was trying to get this into 8.18, @stefans-elastic |
what should I do now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the code doesn't build successfully at the moment.
This PR should target the main
branch, then automation will open a PR to backport this into the 8.x branch if you have applied the backport-8.x
label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But the PR must go through main
then we will backport it into 8.x via automation. You should be able to edit the target branch (and I assume a rebase would be needed).
closing in favor of #42704, which targets |
Proposed commit message
[Netflow] Migrate from log to the logp logging library
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs