Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Netflow code to the logp logging library (targeting main) #42704

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

jrmolin
Copy link
Contributor

@jrmolin jrmolin commented Feb 13, 2025

This was created from #42270, which missed the 8.18 cutoff and had to be re-targeted to main. I'm bad at git rebase, so I just created a patch file and applied it to main. I have incorporated the comments from that PR, but will address any provided now.

Proposed commit message

[Netflow] Migrate from log to the logp logging library

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@jrmolin jrmolin added cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Feb 13, 2025
@jrmolin jrmolin requested a review from a team as a code owner February 13, 2025 22:19
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 13, 2025
Copy link
Contributor

mergify bot commented Feb 13, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @jrmolin? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@jrmolin jrmolin added backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch labels Feb 14, 2025
@jrmolin
Copy link
Contributor Author

jrmolin commented Feb 18, 2025

@andrewkroh Thanks! Could you make sure the labels for backport are correct, please?

Is it okay that the lints are failing?

@andrewkroh andrewkroh removed the backport-8.18 Automated backport to the 8.18 branch label Feb 18, 2025
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those lint issues were pre-existing, and you can merge without those passing, but there's one that looks important that we should address separately. (Ideally, we would make all the checks pass in a standalone PR.)

This change supports a new feature that will go into 8.19. So I changed the backport labels to only target 8.x (which will become 8.19 in the future).

Copy link
Member

@andrewkroh andrewkroh Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error is not nil (line 159) but it returns nil (nilerr)

This linter warning isn't related to your change, but it does look like a real problem whereby we are ignoring an error. Can you open an issue for this and we can address it separately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrmolin jrmolin merged commit d05a070 into elastic:main Feb 19, 2025
20 of 22 checks passed
@jrmolin jrmolin deleted the main-netflow-use-logp branch February 19, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants