-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Netflow code to the logp logging library (targeting main) #42704
Conversation
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
@andrewkroh Thanks! Could you make sure the labels for backport are correct, please? Is it okay that the lints are failing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those lint issues were pre-existing, and you can merge without those passing, but there's one that looks important that we should address separately. (Ideally, we would make all the checks pass in a standalone PR.)
This change supports a new feature that will go into 8.19. So I changed the backport labels to only target 8.x (which will become 8.19 in the future).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error is not nil (line 159) but it returns nil (nilerr)
This linter warning isn't related to your change, but it does look like a real problem whereby we are ignoring an error. Can you open an issue for this and we can address it separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was created from #42270, which missed the 8.18 cutoff and had to be re-targeted to main. I'm bad at
git rebase
, so I just created a patch file and applied it tomain
. I have incorporated the comments from that PR, but will address any provided now.Proposed commit message
[Netflow] Migrate from log to the logp logging library
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs