Add Windows 2025 for unit test steps #42998
Conversation
botelastic
bot
added
needs_team
oakrizan
changed the title
| Set-Location -Path filebeat | ||
| mage build unitTest |
There was a problem hiding this comment.
As far as I see mage supports running from a directory:
-d
directory to read magefiles from (default "." or "magefiles" if exists)
What's the reason for using Set-Location -Path filebeat instead of mage -d filebeat build unitTest?
| Set-Location -Path filebeat | |
| mage build unitTest | |
| mage -d filebeat build unitTest |
There was a problem hiding this comment.
This approach was discussed and agreed during the migration, for some beats -d opt produces error, so in sake of consistency we keep it like that
There was a problem hiding this comment.
cool, do you mind linking the GH issue or PR with the discussion?
There was a problem hiding this comment.
I couldn't find a slack thread or a PR, since it was somewhere in the beginning of 2024. But I recall that this discussion occurred on one of our weekly meetings a year ago.
| @@ -271,6 +272,27 @@ steps: | |||
| - github_commit_status: | |||
| context: "metricbeat: Win 2019 Unit Tests" | |||
|
|
|||
| - label: ":windows: Metricbeat: Win 2025 Unit Tests" | |||
| command: | | |||
| Set-Location -Path metricbeat | |||
There was a problem hiding this comment.
Same as in previous comment
|
qq, what's the reason this is not a backport? |
As mentioned in a description: Based on Support Matrix Windows 2025 should be included in 8.17 for filebeat and metricbeat only. Other active branches do not have Windows 2025 support. |
Are you saying this is not in As far as I know, we always create PRs in the I think,
To avoid any confusion in the future, I'd defer to the backport strategy where we do not contribute to release branches but use PRs into main and the backports. If an exception needs to be considered, it should actually be clear in the description, and somehow agreed beforehand |
|
You can use |
|
@mergify backport 9.0 |
✅ Backports have been created
|
|
@mergify backport 8.18 |
✅ Backports have been created
|
|
@mergify backport 8.x |
✅ Backports have been created
|
(cherry picked from commit beba866)
(cherry picked from commit beba866)
(cherry picked from commit beba866)
Proposed commit message
Based on Support Matrix Windows 2025 should be included in 8.17 for
filebeatandmetricbeatonly. Other active branches do not have Windows 2025 support.Updated Extended Windows unit test group with additional step per beats mentioned above.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Logs
Buildkite builds:
-- filebeat: https://buildkite.com/elastic/filebeat/builds/14161#0195618f-0cb5-4817-aaea-b40d90e895d2
-- metricbeat: https://buildkite.com/elastic/beats-metricbeat/builds/14661#0195618f-0de9-467b-ae6e-ec7ffc2f3ee8