-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[osquery_manager]: Fix osquery_manager data_stream values for 8.6.0 with ingest pipeline #4990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change LGTM. I have not tested this and someone should really test this e2e.
- set: | ||
field: data_stream.type | ||
value: "logs" | ||
ignore_empty_value: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just checking what the default of overwrite
is which is set to true
by default: https://www.elastic.co/guide/en/elasticsearch/reference/current/set-processor.html This is good but maybe to be extra careful, put it in :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this e2e, the clean install and the upgrade scenario. Upgrade testing steps:
|
🌐 Coverage report
|
Package osquery_manager - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=osquery_manager |
What does this PR do?
This adds the ingest pipeline to the osquery_manager in order to fix the known defect in 8.6.0 release where the data_stream fields on the document are set to incorrect values.
Checklist
changelog.yml
file.Related issues
Screenshots
This is the new ingest pipeline that shows up in kibana when the integration is installed
Confirmed that the document is indexed with correct data_stream values
