Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[osquery_manager]: Fix osquery_manager data_stream values for 8.6.0 with ingest pipeline #4990

Merged
merged 3 commits into from
Jan 13, 2023
+19 −1
Merged

[osquery_manager]: Fix osquery_manager data_stream values for 8.6.0 with ingest pipeline #4990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f95c38
Fix osquery_manager data_stream values for 8.6.0 with ingest pipeline
aleksmaus Jan 13, 2023
18feaf5
Addressed code review comment. Added override: true.
aleksmaus Jan 13, 2023
4372ba3
Add changelog entry
aleksmaus Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/osquery_manager/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "1.6.0"
changes:
- description: Fix osquery_manager data_stream values for 8.6.0 with ingest pipeline
type: enhancement
link: https://github.com/elastic/integrations/pull/4990
- version: "1.5.1"
changes:
- description: Update kibana constraint to ^8.6
Expand Down
13 changes: 13 additions & 0 deletions packages/osquery_manager/data_stream/result/elasticsearch/ingest_pipeline/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
description: Pipeline for setting data_stream values
processors:
- set:
field: data_stream.type
value: "logs"
ignore_empty_value: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just checking what the default of overwrite is which is set to true by default: https://www.elastic.co/guide/en/elasticsearch/reference/current/set-processor.html This is good but maybe to be extra careful, put it in :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added overrride: true, and retested e2e again, uncluding upgrade steps.

Here is the ingest pipeline updated, installed from the latest changes in this PR
Screen Shot 2023-01-13 at 10 56 13 AM

override: true
- set:
field: data_stream.dataset
value: "osquery_manager.result"
ignore_empty_value: true
override: true
2 changes: 1 addition & 1 deletion packages/osquery_manager/manifest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
format_version: 1.0.0
name: osquery_manager
title: Osquery Manager
version: 1.5.1
version: 1.6.0
license: basic
description: Deploy osquery with Elastic Agent, then run and schedule queries in Kibana
type: integration
Expand Down