Fix nightly reports #4235
Merged
Fix nightly reports #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e there is no validation in release mode. This is fixing the test in release mode.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4235 +/- ##
===========================================
- Coverage 80.23% 80.23% -0.01%
===========================================
Files 2045 2045
Lines 54182 54184 +2
Branches 6576 6580 +4
===========================================
Hits 43473 43473
Misses 8434 8434
- Partials 2275 2277 +2 ☔ View full report in Codecov by Sentry. |
bmarty
commented
Feb 6, 2025
| return name.takeIf { it.isNotEmpty() } | ||
| ?.let { "#$it:${userIdServerName()}" } | ||
| ?.takeIf { MatrixPatterns.isRoomAlias(it) } | ||
| ?.let { tryOrNull { RoomAlias(it) } } |
There was a problem hiding this comment.
@ganfra do you agree with this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is just moving test classes to the correct package.
Second commit fix the test in release mode:
./gradlew :features:roomdetails:impl:testReleaseUnitTestwas failing before this change because RoomAlias does not fail in release mode when the room alias is invalid.