Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMBR-5172 warn about incompatibility on react native #20

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

jpmunz
Copy link
Contributor

@jpmunz jpmunz commented Oct 7, 2024

No description provided.

@jpmunz jpmunz requested review from a team as code owners October 7, 2024 17:23
Copy link

Copy link

github-actions bot commented Oct 7, 2024

Summary

Status Count
🔍 Total 243
✅ Successful 201
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 42
❓ Unknown 0
🚫 Errors 0
Full Github Actions output


### Known Issues

* We rely on [OpenTelemetry-Swift](https://github.com/open-telemetry/opentelemetry-swift/) which as of today does not
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielDemarco let me know if this accurately describes the issue. I also wasn't sure if this was specific to Cocoapods or relevant to the SPM section as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the problem happens with both dependency management tools.
Description is clear enough though 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, I just changed it to a H2 then so that it is at the same level as the other headers

@jpmunz jpmunz requested a review from eliabsisay October 7, 2024 17:24
@@ -26,6 +26,8 @@ This guide will walk you through integrating Embrace into your React Native appl

* iOS 13.0
* Swift 5
* Known incompatibilities
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpmunz jpmunz requested a review from ArielDemarco October 9, 2024 19:41
@jpmunz jpmunz merged commit 1d172a0 into main Oct 10, 2024
3 checks passed
@jpmunz jpmunz deleted the jpmunz/EMBR-5172-incompatibility-with-dd-rn branch October 10, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants