Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMBR-5172 warn about incompatibility on react native #20

Merged
merged 2 commits into from
Oct 10, 2024
Merged

EMBR-5172 warn about incompatibility on react native #20

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28b31e0
EMBR-5172 warn about incompatibility on react native
jpmunz Oct 7, 2024
e2e9c8b
EMBR-5172 move known issues to top-level header
jpmunz Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/ios/open-source/linking-embrace.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,11 @@ you will need to install an additional pod:
pod 'EmbraceCrashlyticsSupport'
```
:::


### Known Issues

* We rely on [OpenTelemetry-Swift](https://github.com/open-telemetry/opentelemetry-swift/) which as of today does not
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielDemarco let me know if this accurately describes the issue. I also wasn't sure if this was specific to Cocoapods or relevant to the SPM section as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK the problem happens with both dependency management tools.
Description is clear enough though 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, I just changed it to a H2 then so that it is at the same level as the other headers

have official CocoaPods support. We are working with the community to provide this support but in the meantime we
work around this issue by wrapping the OpenTelemetry binary as part of our podspec. In practice this means that our SDK
will not be compatible with other SDKs that do their own version of this work around.
2 changes: 2 additions & 0 deletions docs/react-native/integration/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ This guide will walk you through integrating Embrace into your React Native appl

* iOS 13.0
* Swift 5
* Known incompatibilities
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @eliabsisay

* `@datadog/mobile-react-native`. More details [here](/ios/open-source/linking-embrace/#known-issues).

### Expo

Expand Down