-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix zkillboard socket url #999
base: master
Are you sure you want to change the base?
Conversation
js/app/ui/module/system_killboard.js
Outdated
@@ -727,7 +727,7 @@ define([ | |||
*/ | |||
static initWebSocket(){ | |||
if(!SystemKillboardModule.ws){ | |||
SystemKillboardModule.ws = new WebSocket('wss://zkillboard.com:2096'); | |||
SystemKillboardModule.ws = new WebSocket('wss://zkillboard.com/websocket'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you had this working on your instance but the correct URL seems to be wss://zkillboard.com/websocket/
otherwise you get a permanent redirect and the UI shows as Offline (Red dot).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, yes you are correct, it requires the trailing slash, works fine in our instance as wss://killboard.com/websocket/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you need the "z" in zkillboard? I am still getting my apache server running, so I shamefully, did not get to test.
But when I test a websocket connection on the command line with NodeJS, I need to use: wss://zkillboard.com/websocket/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the trailing slash though. Thank you guys for catching!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, i just copy/pasted from gparent's comment. Full line in my working fork is:
SystemKillboardModule.ws = new WebSocket('wss://zkillboard.com/websocket/');
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited my comment. On my fork I have the working link and rebuilt the static files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Thanks guys!
#995 updating zkillboard socket url