Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zkillboard socket url #999

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix zkillboard socket url #999

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1eb5ca
fix zkillboard socket url
esunder Oct 1, 2020
5943bbb
add trailing slash
esunder Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/app/ui/module/system_killboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ define([
*/
static initWebSocket(){
if(!SystemKillboardModule.ws){
SystemKillboardModule.ws = new WebSocket('wss://zkillboard.com:2096');
SystemKillboardModule.ws = new WebSocket('wss://zkillboard.com/websocket');
Copy link

@gparent gparent Oct 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you had this working on your instance but the correct URL seems to be wss://zkillboard.com/websocket/ otherwise you get a permanent redirect and the UI shows as Offline (Red dot).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, yes you are correct, it requires the trailing slash, works fine in our instance as wss://killboard.com/websocket/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need the "z" in zkillboard? I am still getting my apache server running, so I shamefully, did not get to test.

But when I test a websocket connection on the command line with NodeJS, I need to use: wss://zkillboard.com/websocket/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the trailing slash though. Thank you guys for catching!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, i just copy/pasted from gparent's comment. Full line in my working fork is:

SystemKillboardModule.ws = new WebSocket('wss://zkillboard.com/websocket/');

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited my comment. On my fork I have the working link and rebuilt the static files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks guys!

SystemKillboardModule.wsStatus = 1;
}

Expand Down