Fix raw error crashing HTML reporter, add types, and share error helper #4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was one call site where we were accidentally passing a raw Exception as a message instead of a serialised summary, which was crashing the HTML reporter. This commit corrects this by serialising at that site, adds more types to Message to automatically warn for this category of issue in the future, and pulls the stack trace formatting code out into a public function to provide more error details in more places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was one call site where we were accidentally passing a raw Exception as a message instead of a serialised summary, which was crashing the HTML reporter.
This commit corrects this by serialising at that site, adds more types to Message to automatically warn for this category of issue in the future, and pulls the stack trace formatting code out into a public function to provide more error details in more places.
Checklist
CHANGELOG.md